fix(query-builder): refactor expression tree change emission for consistency - 21.1.x#17082
Open
IMinchev64 wants to merge 4 commits into21.1.xfrom
Open
fix(query-builder): refactor expression tree change emission for consistency - 21.1.x#17082IMinchev64 wants to merge 4 commits into21.1.xfrom
IMinchev64 wants to merge 4 commits into21.1.xfrom
Conversation
IMinchev64
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Query Builder expression tree change emission to be more consistent and to avoid emitting non-serializable data (e.g., Blazor-injected externalObject) when consumers listen to expressionTreeChange.
Changes:
- Added serialization helper in
IgxQueryBuilderComponentand emit a sanitized/cloned expression tree on changes. - Centralized
expressionTreeChange.emit(...)calls inIgxQueryBuilderTreeComponentvia a private helper method. - Updated expression tree comparison logic to ignore
externalObject.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.ts | Emits a serialized/sanitized expression tree (stripping externalObject) for consistency and safer consumption. |
| projects/igniteui-angular/query-builder/src/query-builder/query-builder-tree.component.ts | Routes tree change emissions through a helper and ignores externalObject during tree comparison. |
projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.ts
Outdated
Show resolved
Hide resolved
projects/igniteui-angular/query-builder/src/query-builder/query-builder.component.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Infragistics-Developer-Tools/dev-tools/issues/3208
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)